test: updated to test behaviour according to debug flag state

src/input/input_handling.py

@@ -28,9 +28,15 @@ def _is_str_true(v:str) -> bool:
     ''' convert a string to boolean: if contains True or 1 (or yes), return True '''
     # https://stackoverflow.com/questions/715417/converting-from-a-string-to-boolean-in-python
     return v.lower() in ("yes", "true", "t", "1")
+
+def load_debug_autopopulate() -> bool:
+    return _is_str_true( os.getenv("DEBUG_AUTOPOPULATE_METADATA", "False"))
+    
+    
 # an arbitrary set of defaults so testing is less painful...
 # ideally we add in some randomization to the defaults
-dbg_populate_metadata = _is_str_true( os.getenv("DEBUG_AUTOPOPULATE_METADATA", "False"))
+dbg_populate_metadata = load_debug_autopopulate()
+
 # the other main option would be argparse, where we can run `streamlit run src/main.py -- --debug` or similar
 # - I think env vars are simple and clean enough, it isn't really a CLI that we want to offer debug options, it is for dev.
 if dbg_populate_metadata:

tests/test_demo_input_sidebar.py

@@ -3,6 +3,7 @@ from pathlib import Path
 from io import BytesIO
 from PIL import Image
 import numpy as np
+import os
 
 import pytest
 from unittest.mock import MagicMock, patch
@@ -12,7 +13,7 @@ import time
 
 from input.input_handling import spoof_metadata
 from input.input_observation import InputObservation
-from input.input_handling import buffer_uploaded_files
+from input.input_handling import buffer_uploaded_files, load_debug_autopopulate
 
 from streamlit.runtime.uploaded_file_manager import UploadedFile
 
@@ -184,7 +185,13 @@ def test_no_input_no_interaction():
     at = AppTest.from_file(SCRIPT_UNDER_TEST, default_timeout=10).run()
     verify_initial_session_state(at)
 
-    assert at.session_state.input_author_email == spoof_metadata.get("author_email")
+    dbg = load_debug_autopopulate()
+    #var = at.session_state.input_author_email
+    #_cprint(f"[I] input email is '{var}' type: {type(var)} | is None? {var is None} | {dbg}", PURPLE)
+    if dbg: # autopopulated
+        assert at.session_state.input_author_email == spoof_metadata.get("author_email")
+    else: # should be empty, the user has to fill it in
+        assert at.session_state.input_author_email == ""
 
     # print (f"[I] whole tree: {at._tree}")
     # for elem in at.sidebar.markdown:

tests/test_demo_multifile_upload.py

@@ -26,7 +26,7 @@ from streamlit.testing.v1 import AppTest
 
 
 # for expectations
-from input.input_handling import spoof_metadata
+from input.input_handling import spoof_metadata, load_debug_autopopulate
 from input.input_validator import get_image_datetime, get_image_latlon
 
 
@@ -137,7 +137,11 @@ def test_no_input_no_interaction():
 
     at = AppTest.from_file("src/apptest/demo_multifile_upload.py").run()
     assert at.session_state.observations == {}
-    assert at.session_state.input_author_email == spoof_metadata.get("author_email")
+    dbg = load_debug_autopopulate()
+    if dbg: # autopopulated
+        assert at.session_state.input_author_email == spoof_metadata.get("author_email")
+    else: # should be empty, the user has to fill it in
+        assert at.session_state.input_author_email == ""
 
 def test_bad_email():
     with patch.dict(spoof_metadata, {"author_email": "notanemail"}):